Replace direct http connection with requests.Session() Using connection pool #1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from direct http access to using Session and related Request and PreparedRequest classes. This gives us a number of advantages:
Immediate benefit is fix for network connections issues we had with our sdk integration tests in codefresh
This was tested as follows:
gke_lb-cicd-codefresh_us-central1_env0
is configured locallykubectl -n codefresh-workers exec -it dind-6697ec95c9240c841e27d1f6 -- bash
docker ps
to find the id of our test docker containerType of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features